EQ: Check in new() coefficient blob size before allocating dev and cd#470
Merged
lgirdwood merged 1 commit intothesofproject:masterfrom Oct 10, 2018
Conversation
lgirdwood
requested changes
Oct 8, 2018
Member
lgirdwood
left a comment
lgirdwood
left a comment
There was a problem hiding this comment.
Need some extra trace, also CI failing.
Member
There was a problem hiding this comment.
we probably want to trace this error to report this.
This patch simplifies new() function code and avoids unnecessary allocation of component device and data resources if the the coefficient blob is rejected due to size. The change is identical for FIR and IIR EQs. Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
singalsu
force-pushed
the
eq_new_simplify_check_first_coefficient_blob_size
branch
from
b7f2df7 to
323c55a
Compare
Collaborator
Author
|
@lgirdwood I just pushed the updated version. I've sent email to help understand the CI error logs. I'm testing here successfully with UP2 all my PRs. Though I need to apply the memory.h fix PR #464, otherwise things fail at boot or playback start time. |
lgirdwood
reviewed
Oct 10, 2018
| */ | ||
| if (bs > SOF_EQ_FIR_MAX_SIZE) { | ||
| trace_eq_error("ens"); | ||
| trace_error_value(bs); |
Member
There was a problem hiding this comment.
Btw, trace has been updated so you can pass > 1 value with one call. These can be done as incremental changes in EQ etc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch simplifies new() function code and avoids unnecessary
allocation of component device and data resources if the the coefficient
blob is rejected due to size. The change is identical for FIR and IIR
EQs.
Signed-off-by: Seppo Ingalsuo seppo.ingalsuo@linux.intel.com